[Buildroot] [PATCH 2/3] package/pugixml: enable install of pugixml.pc

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Apr 1 20:42:34 UTC 2019


Hello Bernd,

On Mon,  1 Apr 2019 18:21:57 +0200
Bernd Kuhls <bernd.kuhls at t-online.de> wrote:

> Needed for waylandpp >= 0.2.4 to detect pugixml:
> https://github.com/NilsBrause/waylandpp/commit/0a61175003a0a34038e39092918768360d2dd1da#diff-af3b638bc2a3e6c650974192a53c7291R39
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> ---
>  package/pugixml/pugixml.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/pugixml/pugixml.mk b/package/pugixml/pugixml.mk
> index 6f214c4de8..3c80622b11 100644
> --- a/package/pugixml/pugixml.mk
> +++ b/package/pugixml/pugixml.mk
> @@ -30,5 +30,8 @@ ifdef PUGIXML_BUILD_DEFINES
>  PUGIXML_CONF_OPTS += -DBUILD_DEFINES="$(subst $(space),;,$(PUGIXML_BUILD_DEFINES))"
>  endif
>  
> +PUGIXML_CONF_OPTS += -DBUILD_PKGCONFIG=ON
> +HOST_PUGIXML_CONF_OPTS += $(PUGIXML_CONF_OPTS)

This is not good: we don't want to have the host version of pugixml
have its configuration affected by the options that change the
configuration of the target pugixml variant.

In addition, for the host variant, this is doing much more than
enabling the installation of pugixml.pc, since all other
PUGIXML_CONF_OPTS (especially -DBUILD_DEFINES) will be passed to the
host variant.

Could you address this issue and send a v2 ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list