[Buildroot] [PATCH 01/14] package/perl-class-inspector: bump to version 1.34
thomas.petazzoni at bootlin.com
Mon Apr 1 20:12:22 UTC 2019
On Sun, 31 Mar 2019 19:44:36 +0200
Francois Perrad <fperrad at gmail.com> wrote:
> Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
I have applied your series of 14 patches, but there were a number of
issues with them, which I fixed. I'll reply to the problematic patches.
I have to say that I kind of expect a regular contributor like you to
not submit patches with such issues. The first one is in this patch.
> # computed by scancpan
> -sha256 3ed0185f73a0570b72a2dc95c6bde500dc800c6f778ccbd688df4f88e6e65232 LICENSE
> +sha256 401fe9c98bdb5707df71447fb93141f8cb2d85337d45505f5ae50a776a3f6666 LICENSE
When the license file hash changes, there must be a note in the commit
log that explains what changed. Otherwise, we can't know if the
contributor has done a proper check, or just blindly updated the hash.
The rule is clear: any change to the license files MUST be explained
in the commit log.
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
More information about the buildroot