[Buildroot] [PATCH 1/1] boot/arm-trusted-firmware: support debug mode
thomas.petazzoni at bootlin.com
Thu Nov 29 22:05:54 UTC 2018
On Thu, 22 Nov 2018 16:22:38 +0100, Etienne Carriere wrote:
> When the trusted firmware is built with debug support (DEBUG defined),
> the generated images are located at a specific path. The non debug
> images are located in generated directory build/<platform>/release/
> while the debug images are located in generated directory
> This change introduces boolean BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG
> to define whether the release or debug configuration is used to build
> trusted firmware. Note that enabling trusted firmware debug support, i.e
> BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="... DEBUG=1 ..."
> without enabling BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG will fail since
> buildroot will get generated files from the wrong path.
> Signed-off-by: Etienne Carriere <etienne.carriere at linaro.org>
What is this debug mode doing exactly ?
We already have a global BR2_ENABLE_DEBUG option to enable building
with debugging symbols. I am wondering if we should use that option as
well, or like you did, introduce a separate option. Perhaps for
something like ATF, that is very low-level and HW-specific, a separate
debug option is OK.
> +config BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG
> + bool "Debug mode of the trusted firmware"
> + default n
"default n" is not needed, since it's the default. Not need to resend
just for that, we can fixup when applying.
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
More information about the buildroot