[Buildroot] [PATCH] rpm: really take DEPENDENCIES into account
peter at korsgaard.com
Mon Nov 26 16:16:12 UTC 2018
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:
> Commit e7af4033c32560594ddbd457b68f6d3713662a26 ("rpm: use the new
> gettext logic") introduced a really nasty bug: by adding
> $(TARGET_NLS_DEPENDENCIES) to RPM_DEPENDENCIES, it completely
> overwrote the existing value of RPM_DEPENDENCIES, entirely masking all
> mandatory RPM dependencies.
> rpm is fairly towards the end of the alphabet, and most other
> mandatory dependencies (berkeleydb, host-pkgconf, file and popt)
> appear earlier by alphabetic ordering. Only zlib was afterwards, but
> since file depends on zlib, it was always built before. This probably
> explains why our autobuilders haven't encountered a single build
> However, a simple "make rpm" clearly exhibits the failure, and
> obviously the upcoming per-package folder mechanism makes such bugs
> even more obvious.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> I don't know who was this guy @free-electrons.com who did this silly
> change, but something wasn't quite right with him :-)
Committed to 2018.02.x and 2018.08.x, thanks.
Bye, Peter Korsgaard
More information about the buildroot