[Buildroot] [PATCH v2 3/6] testing/infra/builder: build with target and environment

Ricardo Martincoski ricardo.martincoski at gmail.com
Sun Nov 18 21:35:05 UTC 2018


Hello,

Another nit that can be fixed while applying.

On Sat, Nov 17, 2018 at 01:56 AM, Matt Weber wrote:

> From: Ricardo Martincoski <ricardo.martincoski at datacom.ind.br>
> 
> Make the builder able to call 'VAR1=1 make VAR2=2 target'.
> 
> Allow to send extra parameters to be added to the end of make command
> line. It can be used for these purposes:
>  - to configure a br2-external, by passing 'BR2_EXTERNAL="dir"';
>  - to specify a make target, such as 'foo-source'.
> 
> Allow to add variables to the environment in which make runs. It can be
> used to override values from environment, such as 'BR2_DL_DIR="dl"'.
> 

> This change will be needed when adding a common class to test the git
> download infra.

This is not untrue.
But in the context of your series, perhaps it could be replaced by:
"
This change will be needed when adding support to br2-externals to the
test infra.
"
And who applies could even tweak this to a better phrase.

> 
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski at datacom.ind.br>
> Cc: Arnout Vandecappelle <arnout at mind.be>
> Signed-off-by: Matt Weber <matthew.weber at rockwellcollins.com>

It feels weird to add a tag to my own patch :-)
But I reviewed it and the contents are OK.


Regards,
Ricardo


More information about the buildroot mailing list