[Buildroot] [PATCH 1/2] fs: Add common rootfs dependencies to PACKAGES
dev at andin.de
Mon Nov 12 12:53:05 UTC 2018
Am 09.11.18 um 23:11 schrieb Arnout Vandecappelle:
> On 08/11/2018 14:04, Andreas Naumann wrote:
>> +PACKAGES += $(ROOTFS_COMMON_DEPENDENCIES)
> I don't really like this, for the simple reason that it will enable the
> dependencies even if they are not needed because we're not building any rootfs.
good point, I dont like that either. I'd propose to change/move the
patch into something like
PACKAGES += $$(filter-out $$(PACKAGES),$$(ROOTFS_COMMON_DEPENDENCIES))
inside the rootfs-conditional clause at the bottom of fs/common.mk.
Actually I'm not sure the filter-out stuff is really needed since
duplicate targets may accumulate in PACKAGES anyway.
> It's a small thing though, and working around it is a lot more complicated (you
> could e.g. select a new Config.in symbol that is selected by all the rootfses).
> And when we ever get the Config.in.host for all host packages, it's solved
> already. So
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>> $(ROOTFS_COMMON_TAR): ROOTFS=COMMON
>> $(ROOTFS_COMMON_TAR): FAKEROOT_SCRIPT=$(FS_DIR)/fakeroot.fs
> buildroot mailing list
> buildroot at busybox.net
More information about the buildroot