[Buildroot] [PATCH v2] libcurl: Allow selection of TLS package libcurl will use
peter at korsgaard.com
Fri Nov 9 22:40:51 UTC 2018
>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
>> + prompt "SSL/TLS library to use"
>> +config BR2_PACKAGE_LIBCURL_OPENSSL
>> + bool "OpenSSL"
>> + depends on BR2_PACKAGE_OPENSSL
> I don't really like this depends. I would rather revert it into a select. So:
> prompt "SSL/TLS library to use"
> config BR2_PACKAGE_LIBCURL_OPENSSL
> bool "openssl"
> select BR2_PACKAGE_OPENSSL
> config BR2_PACKAGE_LIBCURL_NONE
> bool "disable TLS"
> Note that that means that libcurl will by default select openssl, which was not
> the case before. However, I think it makes complete sense to default to enabling
> TLS support in libcurl. Peter, what do you think? This would obviously have to
> be mentioned in the release notes because the behaviour of existing configs
> would change.
Either that or add a:
depends on BR2_PACKAGE_OPENSSL || BR2_PACKAGE_GNUTLS || \
BR2_PACKAGE_LIBNSS || BR2_PACKAGE_MBEDTLS
To the choice option and drop the _LIBCURL_NONE variant. With that we
have the same behaviour as before, except that you _CAN_ select the TLS
provider in case multiple providers are available.
Bye, Peter Korsgaard
More information about the buildroot