[Buildroot] [PATCH 2/3] package/alsa-lib: drop patch 0002-alsa-lib-provide-dummy-definitions-of-RTLD_-if-neces.patch

Peter Korsgaard peter at korsgaard.com
Wed Nov 7 22:48:45 UTC 2018


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > The description of this patch was no longer correct: it no longer
 > provided dummy definitions of RTLD_* macros since commit
 > ccad7db515fa79d2331e4e949aafb32eca0b5214 ("alsa-lib: bump to version
 > 1.1.6"). All it did is make two <dlfcn.h> inclusions optional.

 > However, this is no longer needed, since the alsa-lib code base
 > contains four inclusions of <dlfcn.h>, which are all properly handled:

 >  - include/local.h, the include is guarded by #ifdef HAVE_LIBDL

 >  - modules/mixer/simple/sbasedl.c, modules are only built if
 >    BUILD_MODULES is enabled, and BUILD_MODULES is only enabled if
 >    HAVE_LIBDL is enabled

 >  - src/mixer/simple_abst.c, this file is only built if BUILD_MODULES
 >    is enabled, which itself is only enabled if HAVE_LIBDL is enabled

 >  - src/pcm/pcm_meter.c, this file is only built if
 >    BUILD_PCM_PLUGIN_METER is enabled, and this is not enabled if
 >    HAVE_LIBDL is not enabled.

 > Conclusion: the patch can be dropped. The third patch is renumbered as
 > appropriate.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list