[Buildroot] [PATCH 1/2] ngrep: bump to version 1.47

Arnout Vandecappelle arnout at mind.be
Tue Nov 6 00:14:48 UTC 2018



On 04/11/18 12:34, Baruch Siach wrote:
> Hi Fabric,
> 
> Fabrice Fontaine writes:
>> Dear Thomas,
>> Le dim. 4 nov. 2018 à 11:19, Thomas Petazzoni
>> <thomas.petazzoni at bootlin.com> a écrit :
>>>
>>> Hello,
>>>
>>> On Sat, 3 Nov 2018 23:01:07 +0100, Fabrice Fontaine wrote:
>>>
>>>>> So PCRE is not mandatory.
>>>> Indeed, PCRE is not really "mandatory", ngrep use GNU regex by default
>>>> but this was already the case before the bump (in version 1.45): see
>>>> https://github.com/jpr5/ngrep/blob/V1_45/configure.in.
>>>> I didn't want to change this behavior when bumping the package and I
>>>> could find why pcre wasn't made optional in the initial commit back in
>>>> 2011.
>>>> However, I'll add a third patch in my serie to make pcre an optional
>>>> dependency before bumping the package..
>>>
>>> Indeed, it could be a third patch.
>> OK, when I tried to enable GNU regex (on 1.47), I got the following error:
>> /usr/bin/make w -j --jobserver-fds=3,4 -C regex-0.12 regex.o
>> make[2]: Entering directory
>> '/home/fabrice/buildroot/output/build/ngrep-1_47/regex-0.12'
>> make[2]: *** No rule to make target 'w'.  Stop.
>>
>> This error is raised by this command:
>> $(MAKE) $(MAKEFLAGS) -C $(REGEX_DIR) $(notdir $(REGEX_OBJS))
>>
>> which means that MAKEFLAGS is set to "w -j --jobserver-fds=3,4".
>> I don't understand where this "w" and not "-w" is coming from. Do you
>> have any advice or clue?
> 
> This is most likely related to mismatch of make versions being used when
> we build our own host-make. See the discussion in this thread related to
> boa:
> 
>   http://lists.busybox.net/pipermail/buildroot/2018-October/232957.html
> 
> There is no fix to this issue yet.

 Since we don't really want to pass any flags from Buildroot down to the package
build systems, perhaps we should just set

override MAKE := make <jlevel stuff>

at the top of package/Makefile.in? I've done a quick test, and it seems to fix
the boa issue at least.

 This would revert the following commit though:

commit 4705b600764c683e934da7db54f7971a3c647e8a
Author: Ulf Samuelsson <ulf.samuelsson at atmel.com>
Date:   Tue Jul 17 14:09:07 2007

    Ensure we use host 'make', even when building 'make' in buildroot

but that doesn't explain why it is not wanted to use the Buildroot-built make...


 Regards,
 Arnout

 Regards,
 Arnout



More information about the buildroot mailing list