[Buildroot] [PATCH v2 4/5] check-package: ignore external.mk
ricardo.martincoski at gmail.com
Sun Nov 4 04:12:08 UTC 2018
The external.mk file in a br2-external usually contains raw makefile
targets. This file is common code and not a package recipe so it should
not be tested against the code-style of a package .mk file.
When using this script to check files in a br2-external tree, usually
the user is responsible for not passing files that check-package do not
understand. But external.mk is special because it is part of the
br2-external structure, so it is likely someone expects it to be
checkable by an in-tree script.
Instead of adding another blob to the manual, just ignore this file.
Only do that when a br2-external is being tested (so with option -b
passed to the script) and also check that it is on the root path of the
br2-external to allow someone to have a package called external.
Reported on bug #11271.
Reported-by: Vitaliy Lotorev <lotorev at gmail.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Changes v1 -> v2:
- no changes
utils/check-package | 3 +++
1 file changed, 3 insertions(+)
diff --git a/utils/check-package b/utils/check-package
index 3dbc28b0a2..3969ec3ec7 100755
@@ -71,6 +71,9 @@ def get_lib_from_filename(fname):
+ if os.path.basename(fname) == "external.mk" and os.path.exists(fname[:-2] + "desc"):
+ return None
More information about the buildroot