[Buildroot] [PATCH 1/2] ngrep: bump to version 1.47
fontaine.fabrice at gmail.com
Sat Nov 3 22:01:07 UTC 2018
Le sam. 3 nov. 2018 à 22:42, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
> On Thu, 1 Nov 2018 14:23:25 +0100, Fabrice Fontaine wrote:
> > - Add an upstream patch to fix --enable-pcre
> If there is a --enable-pcre option, it is a strong indication that PCRE
> is not mandatory. Indeed:
> $ ./configure --help
> --enable-pcre use PCRE instead of GNU regex (default GNU)
> So PCRE is not mandatory.
Indeed, PCRE is not really "mandatory", ngrep use GNU regex by default
but this was already the case before the bump (in version 1.45): see
I didn't want to change this behavior when bumping the package and I
could find why pcre wasn't made optional in the initial commit back in
However, I'll add a third patch in my serie to make pcre an optional
dependency before bumping the package..
> > -NGREP_LIBS = -lpcap -lpcre
> Since this variable no longer exists...
Yes, -lpcap and -lpcre are now correctly added by the project.
> > ifeq ($(BR2_STATIC_LIBS),y)
> > NGREP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`
> > endif
> > @@ -20,7 +20,6 @@ NGREP_CONF_ENV += LIBS+="$(NGREP_LIBS)"
> This assignment becomes totally pointless.
OK, I'll replace it by:
NGREP_CONF_ENV += LIBS="$(STAGING_DIR)/usr/bin/pcap-config --static
> > NGREP_CONF_OPTS = \
> > --with-pcap-includes=$(STAGING_DIR)/usr/include/pcap \
> > --enable-pcre \
> > - --with-pcre=$(STAGING_DIR)/usr \
> > --disable-dropprivs \
> > --disable-pcap-restart
> You should add a --disable-tcpkill here, and then in your PATCH 2/2,
> add the optional dependency on libdnet.
OK, I'll make a v2 with this update (and the other ones)
> Your series on wireshark has the same issue: the first patch should
> ensure all new optional dependencies are unconditionally disabled, and
> then follow-up patches should enable them conditionally. This is
> necessary for a correctly bisectable patch series. When patches are so
> close in the same series, it's not a big big deal, but it's always
> better when it's done really correctly.
OK, I'll do a v2 of wireshark serie too.
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
More information about the buildroot