[Buildroot] [PATCH v2] scanpypi: use archive file name to specify the extraction folder

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Nov 2 20:36:40 UTC 2018


On Fri,  2 Nov 2018 14:45:01 +0100, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists at googlemail.com>
> Some packages have archive name that is different from package name.
> For example websocket-client's archive name is websocket_client-*.tar.gz.
> scanpypi expects the temporary extract folder to be:
> /tmp-folder/BR-package-name/PyPI-packagename-and-version
> In the case of websocket-client package the real extraction folder
> will be different from the expected one because of the '_' in the
> archive file name.
> Use archive file name instead of package name to specify the extraction
> folder. As the version is already part of this file, we don't need to
> specify it.
> Bonus: remove obsolete "return None, None" as the function doesn't return
> anything. OSError class doesn't provide "message" member, so replace it
> with "strerror".

I've applied to master, but I believe it should perhaps have been two
separate patches. Indeed, I don't see the relationship between the use
of the archive file name, and the change around "return None, None".


Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering

More information about the buildroot mailing list