[Buildroot] [PATCH] Config.in: add BR2_DL_DIR_OPTS

Yann E. MORIN yann.morin.1998 at free.fr
Thu Nov 1 09:06:16 UTC 2018


Markus, All,

On 2018-10-31 14:39 -0700, Markus Mayer spake thusly:
> Provide a simple mechanism to pass extra arguments to "mkdir" when
> creating download directories. This can be helpful if one needs the
> download directories to be writable multiple users ("shared download
> cache").

In retrospect, I think our enforcing of umask globally is wrong.

It was added in commit bee5745ccc2 (Makefile: don't depend on the umask)
under the requirements that modes in target/ be predicatble.

Although that is indeed a good reason, I think we should have instead
ensured those modes with a plain chmod on target/ during the
target-finalize step.

That way, we could drop our umask override, and let the user define
whatever umask they need.

Regards,
Yann E. MORIN.

> Signed-off-by: Markus Mayer <mmayer at broadcom.com>
> ---
>  Config.in               | 14 ++++++++++++++
>  package/pkg-download.mk |  2 +-
>  2 files changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/Config.in b/Config.in
> index 42cdf7a3ebdc..0442d8403b4a 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -214,6 +214,20 @@ config BR2_DL_DIR
>  
>  	  The default is $(TOPDIR)/dl
>  
> +config BR2_DL_DIR_OPTS
> +	string "Options for mkdir when it creates BR2_DL_DIR"
> +	default ""
> +	help
> +	  Specify command line options for the mkdir command when it
> +	  creates BR2_DL_DIR.
> +
> +	  For example, this can be used to specify directory permissions
> +	  (say, "-m 0775") for directories inside BR2_DL_DIR. One would
> +	  want this if the download directory is a shared "cache" for
> +	  multiple users, so everybody can write to these directories.
> +
> +	  The default empty (no additional options).
> +
>  config BR2_HOST_DIR
>  	string "Host dir"
>  	default "$(BASE_DIR)/host"
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index 73ea2a69f829..d6bfe2bb06d0 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -91,7 +91,7 @@ endif
>  endif
>  
>  define DOWNLOAD
> -	$(Q)mkdir -p $($(PKG)_DL_DIR)
> +	$(Q)mkdir $(BR2_DL_DIR_OPTS) -p $($(PKG)_DL_DIR)
>  	$(Q)$(EXTRA_ENV) $(FLOCK) $(DL_WRAPPER) \
>  		-c '$($(PKG)_DL_VERSION)' \
>  		-d '$($(PKG)_DL_DIR)' \
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list