[Buildroot] [PATCH next v6 09/10] package/pkg-generic: make libtool .la files compatible with per-package directories

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Nov 30 10:20:12 UTC 2018


Hello,

On Sun, 25 Nov 2018 18:57:02 +0100, Yann E. MORIN wrote:

> Since I really want this topic to come to a conclusion sooner than
> later, and since the solution is good-enough for now:
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

Thanks. However, since I have changed a bit this patch for v7, I will
not include your Reviewed-by.

> I don't find it very clean that we shoe-horn such preparation in the
> generic rules; I'd rather we use a hook mechanism, which we can define
> for the prepare-per-package-directory macro to call.

I understand your proposal. However, I think that it's premature to
introduce such a hook mechanism: for now there's only one such fixup to
do. Let's wait until we have a few.

I have moved the code outside of the package step, into a helper
function. It looks a bit nicer, and perhaps if we need to do other
fixups this helper function can be extended to be the one doing all the
per-package related fixups.

What do you think ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list