[Buildroot] [PATCH 02/11] alsa-utils: update DEPENDENCIES to fft-single and add select in Config.in

Gwenhael Goavec-Merou gwenj at trabucayre.com
Thu Nov 29 05:38:24 UTC 2018


Hi Baruch

On Thu, 29 Nov 2018 06:24:15 +0200
Baruch Siach <baruch at tkos.co.il> wrote:

> Hi Gwenhael Goavec-Merou,
> 
> Gwenhael Goavec-Merou writes:
> 
> > From: Gwenhael Goavec-Merou <gwenhael.goavec-merou at trabucayre.com>
> >
> > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou at trabucayre.com>
> > ---
> >  package/alsa-utils/Config.in     | 5 ++---
> >  package/alsa-utils/alsa-utils.mk | 2 +-
> >  2 files changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
> > index 012f28aef4..950278d173 100644
> > --- a/package/alsa-utils/Config.in
> > +++ b/package/alsa-utils/Config.in
> > @@ -74,15 +74,14 @@ config BR2_PACKAGE_ALSA_UTILS_ASEQNET
> >  	select BR2_PACKAGE_ALSA_LIB_SEQ
> >  
> >  config BR2_PACKAGE_ALSA_UTILS_BAT
> > +	select BR2_PACKAGE_FFTW
> > +	select BR2_PACKAGE_FFTW_PRECISION_SINGLE
> >  	bool "bat"
> >  	help
> >  	  ALSABAT (ALSA Basic Audio Tester) is a simple command-line
> >  	  utility intended to help automate audio driver and sound
> >  	  server testing with little human interaction.
> >  
> > -	  Note that analysis support in alsabat requires fftw single
> > -	  precision.
> > -
> >  config BR2_PACKAGE_ALSA_UTILS_IECSET
> >  	bool "iecset"
> >  	select BR2_PACKAGE_ALSA_LIB_PCM
> > diff --git a/package/alsa-utils/alsa-utils.mk
> > b/package/alsa-utils/alsa-utils.mk index 986a745399..9e0094f343 100644
> > --- a/package/alsa-utils/alsa-utils.mk
> > +++ b/package/alsa-utils/alsa-utils.mk
> > @@ -41,7 +41,7 @@ endif
> >  ifeq ($(BR2_PACKAGE_ALSA_UTILS_BAT),y)
> >  ALSA_UTILS_CONF_OPTS += --enable-bat
> >  # Analysis support requires fftw single precision
> > -ALSA_UTILS_DEPENDENCIES += $(if $(BR2_PACKAGE_FFTW_PRECISION_SINGLE),fftw)
> > +ALSA_UTILS_DEPENDENCIES += fftw-single  
> 
> This turns the optional fftw dependency into a mandatory one. Is there a
> reason for that?
>
It may be a misunderstanding on my part but it is explicitly noted "Analysis
support requires fftw single". This assumption is confirmed by my distribution
(gentoo) where fftw is added as dependency when bat option is selected.
> 
> >  else
> >  ALSA_UTILS_CONF_OPTS += --disable-bat
> >  endif  
> 
> baruch
> 
Gwen


More information about the buildroot mailing list