[Buildroot] [PATCH next v4 6/6] core: implement per-package SDK and target

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Nov 20 10:29:00 UTC 2018


Hello,

On Tue, 20 Nov 2018 11:22:00 +0100, Arnout Vandecappelle wrote:

> >> I personally find it OK, even though it's a bit annoying to introduce
> >> yet another step just for the sake of pkg-kconfig.  
> 
>  Me too. And I'm not even sure if it really solves the pkg-kconfig problem. I
> have a hard time remembering what all the issues were there.
> 
>  Perhaps, though, we should have a more general strategy of a per-infra
> definition of what the steps are, instead of having a fixed sequence of steps.
> I.e., have a pattern that should be followed by an infra-specific step to make
> sure things are done correctly. So, for the kconfig case we would have an extra
> kconfig_fixup step (we already have the stamp file, but it's not a real step
> with hooks and the KCONFIG_DEPENDENCIES were strapped on as an afterthought),
> and for the autoreconf case we would have an extra autoreconf step (instead of a
> hook).

And so those "injected" steps should take care of preparing the
per-package folder with whatever dependencies they need ?

This is probably something that can be done to fix the pkg-kconfig
stuff without having to create a new "prepare" step in the generic
infrastructure.

>  But the problem is, for pkg-kconfig, we actually need the prepare stuff to be
> done in the build directory, not the source directory... So it *still* doesn't
> match.

Right.

> > above, because autoreconf will also require the same dependencies as the
> > configure step.  
> 
>  ... not because of this. Most dependencies are only really needed in the
> configure step, it's only some of them (host-automake etc. obviously, but also
> host-autoconf-archive and host-pkg-config for the .m4 files) that are needed for
> the autoreconf. So if it is split, we would need to move some dependencies to
> _PREPARE_DEPENDENCIES.

At this point, I don't want to change anything for autoreconf. It is
part of the configure step, it works as it is. I'd like to fix just the
pkg-kconfig situation. I'll try to do that within pkg-kconfig.mk.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list