[Buildroot] [PATCH v3 2/3] make: drop gnumake/gmake aliases for host-make

yann.morin at orange.com yann.morin at orange.com
Tue Nov 20 07:22:06 UTC 2018


Peter, All,

On 2018-11-19 17:25 +0100, Peter Korsgaard spake thusly:
> Now that glibc no longer checks for gnumake / gmake, these aliases can be
> removed.
> 
> Signed-off-by: Peter Korsgaard <peter at korsgaard.com>

Reviewed-by: "Yann E. MORIN" <yann.morin at orange.com>

Note that, even if the system does have gmake or gnumake, they are no
longer detected since we do force what make to use recursively in glibc,
which was not the case previously (just saying for posterity, because I
had to think twice before reviewing that).

Regards,
Yann E. MORIN.

> ---
> v3: No changes
> v2: No changes
> 
>  package/make/make.mk | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/package/make/make.mk b/package/make/make.mk
> index 790391c76e..1471576850 100644
> --- a/package/make/make.mk
> +++ b/package/make/make.mk
> @@ -23,15 +23,5 @@ endif
>  HOST_MAKE_DEPENDENCIES = host-pkgconf
>  HOST_MAKE_CONF_OPTS = --without-guile
>  
> -# Some packages, like glibc, are looking for gnumake or gmake before
> -# make program.
> -# Create these symlink to use make binary generated by Buildroot for
> -# the host.
> -define HOST_MAKE_INSTALL_GNUMAKE
> -	ln -fs make $(HOST_DIR)/bin/gnumake
> -	ln -fs make $(HOST_DIR)/bin/gmake
> -endef
> -HOST_MAKE_POST_INSTALL_HOOKS += HOST_MAKE_INSTALL_GNUMAKE
> -
>  $(eval $(autotools-package))
>  $(eval $(host-autotools-package))
> -- 
> 2.11.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
| +33 534.541.179 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
|      yann.morin (at) orange.com      |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.



More information about the buildroot mailing list