[Buildroot] [PATCH v2 4/6] testing/infra/basetest: support br2-external

Ricardo Martincoski ricardo.martincoski at gmail.com
Sun Nov 18 21:41:53 UTC 2018


Hello,

Another nit that can be fixed while applying.

On Sat, Nov 17, 2018 at 01:56 AM, Matt Weber wrote:

> From: Ricardo Martincoski <ricardo.martincoski at datacom.ind.br>
> 

> This change will be needed when adding a common class to test the git
> download infra.

Just like in patch 3, this is not untrue.
But in the context of your series, perhaps it could be replaced by:
"
Some upcoming test cases can use one or more br2-external trees as
fixtures that provide packages used only in runtime tests.

Add support for br2-external into the BRTest class. Any test case can
then provide a list of paths for be used as br2-external trees during
the build of the image to be tested.
"
And who applies it could even tweak this to a better phrase.

> 
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski at datacom.ind.br>
> Cc: Arnout Vandecappelle <arnout at mind.be>
> Signed-off-by: Matt Weber <matthew.weber at rockwellcollins.com>
> ---

I reviewed it and the contents are OK.


Regards,
Ricardo


More information about the buildroot mailing list