[Buildroot] [PATCH v3 2/3] test-pkg: Use the correct config prefix when merging

Nasser Afshin afshin.nasser at gmail.com
Wed Nov 14 09:04:47 UTC 2018


Hi Arnout,
On Wed, Nov 14, 2018 at 09:24:32AM +0100, Arnout Vandecappelle wrote:
>  Hi Nasser,
> 
>  Two remarks for your future contributions.
> 
> On 14/11/2018 08:49, Nasser Afshin wrote:
> > Hi Petr
> > On Wed, Nov 14, 2018 at 08:17:33AM +0100, Petr Vorel wrote:
> >> Hi Nasser,
> >>
> >>> From: Nasser Afshin <Afshin.Nasser at gmail.com>
> >>
> >>> We should use an empty prefix as we do not have any prefix.
> >>> Note that BR2_ is mere a convention.
> >>
> >>> Signed-off-by: Nasser Afshin <Afshin.Nasser at gmail.com>
> 
>  When you send a v2 or later, please include a patch changelog, like so:
> 
> ---
> v2: remove quotes from the empty CONFIG_ assignment (suggested by Peter Vorel)
> 
> 
>  The --- splits the commit message from additional notes that won't be included
> when the patch is applied.
> 
I thought it's a tiny change. You're right I should have included the
changelog anyway.
> >> Reviewed-by: Petr Vorel <petr.vorel at gmail.com>
> > Sorry I forgot to mention that. Resent.
> 
>  There is no need to resend for that: patchwork will include it automatically.
Ok. Thank you for reviewing my patch and sending your tips.
Sorry for being a novice.
> 
> 
>  Regards,
>  Arnout
> 
> >>> ---
> >>>  utils/test-pkg | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>> diff --git a/utils/test-pkg b/utils/test-pkg
> >>> index aa91ee02cf..e4f68ed061 100755
> >>> --- a/utils/test-pkg
> >>> +++ b/utils/test-pkg
> >>> @@ -129,7 +129,7 @@ build_one() {
> >>
> >>>      mkdir -p "${dir}"
> >>
> >>> -    support/kconfig/merge_config.sh -O "${dir}" \
> >>> +    CONFIG_= support/kconfig/merge_config.sh -O "${dir}" \
> >> Thanks for a change.
> >>
> >>
> >> Kind regards,
> >> Petr
> > Kind regards,
> > Nasser
> > 
Kind regards,
Nasser


More information about the buildroot mailing list