[Buildroot] [PATCH] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML

Arnout Vandecappelle arnout at mind.be
Tue Nov 13 23:42:45 UTC 2018



On 13/11/2018 21:21, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 13 Nov 2018 21:59:08 +0200, Baruch Siach wrote:
>> Commit fa0d1ebff99 (libnftnl: bump to version 1.0.9) removed the mxml
>> dependency. Remove the redundant BR2_PACKAGE_LIBNFTNL_XML config symbol
>> as well.
>>
>> Cc: Yegor Yefremov <yegorslists at googlemail.com>
>> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> 
> Do we need Config.in.legacy handling ?
> 
> We normally add Config.in.legacy handling when removing options, but on
> the other hand, this option has had no effect since 2018.02.

 Legacy handling is there mostly to make sure the appropriate alternative option
can be selected. In this case there is no alternative.

 Also, compare this to a situation where it would have been an automatic
optional dependency: in that case, the feature also disappears silently.

 That said: legacy handling costs nothing and can be useful for some users. And
it can be backported to 2018.02.x.

 Regards,
 Arnout


More information about the buildroot mailing list