[Buildroot] [PATCH 4/6 v2] fs: split devices and permissions tables

Arnout Vandecappelle arnout at mind.be
Mon Nov 12 22:46:32 UTC 2018



On 12/11/2018 18:33, Yann E. MORIN wrote:
> Currently, we conflate device tables and permissions tables, on the
> premise they are both created and applied with the same tool, makedevs.
> 
> Split the two, in to their own final aggregated tables and their own
> call to makedevs.

 Sorry, I don't think there is a good reason to split them up. I don't think
this enables any other improvements either - the following two patches don't
depend on this, right? I also don't feel that this change makes the code easier
to understand (not more difficult either, but if it ain't broken, don't fix it).

 So nack from me.

 Regards,
 Arnout

> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Arnout Vandecappelle <arnout at mind.be>
> ---
>  fs/common.mk | 27 +++++++++++++++++++--------
>  1 file changed, 19 insertions(+), 8 deletions(-)
[snip]


More information about the buildroot mailing list