[Buildroot] [PATCH 1/1] libkrb5: fix build on riscv

Fabrice Fontaine fontaine.fabrice at gmail.com
Sun Nov 11 20:15:10 UTC 2018


Dear Thomas,
Le dim. 11 nov. 2018 à 20:53, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
>
> Hello,
>
> On Sun, 11 Nov 2018 18:52:10 +0100, Fabrice Fontaine wrote:
> > Define _REENTRANT otherwise pthread detection will fail
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/39a51d0c3feab74edd8a17c9174d031ccc7ffe1d
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > ---
> >  package/libkrb5/libkrb5.mk | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
> > index d9d7160ae8..6534c069ee 100644
> > --- a/package/libkrb5/libkrb5.mk
> > +++ b/package/libkrb5/libkrb5.mk
> > @@ -52,7 +52,14 @@ else
> >  LIBKRB5_CONF_OPTS += --without-readline
> >  endif
> >
> > -ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> > +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> > +# gcc on riscv doesn't define _REENTRANT when -pthread is passed while
> > +# it should. Compensate this deficiency here otherwise libkrb5 configure
> > +# script doesn't find that thread support is enabled.
> > +ifeq ($(BR2_riscv),y)
> > +LIBKRB5_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D_REENTRANT"
> > +endif
>
> You did a similar change in libmicrothttpd, for which the same fix was
> already done for ARC. Any idea why libmicrohttpd needs this hack for
> both ARC and RISC-V, while libkrb5 would need it only for RISC-V ?
I didn't try to build libkrb5 on ARC but I found that back in 2016,
for libmicrohttpd, you were writing that "Fixing the compilers is
definitely the right thing to do":
https://patchwork.ozlabs.org/patch/643857.
Perhaps since that time, the ARC toolchains have been fixed?
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice


More information about the buildroot mailing list