[Buildroot] [PATCH v2 00/12] default runtime test case for python packages v2

Ricardo Martincoski ricardo.martincoski at gmail.com
Sat Nov 10 02:15:21 UTC 2018

Hello Thomas,

On Tue, Nov 06, 2018 at 05:56 AM, Thomas Petazzoni wrote:

> On Mon, 05 Nov 2018 23:57:15 -0200, Ricardo Martincoski wrote:
>> >  - Use an integer for the Python version variable, rather than a
>> >    string, there is really no need for this to be a string I believe ?  
>> You are correct. There is no need for a string. I will use an integer.
> On the other hand, this python_version = 2/3 is only one line, and it
> saves only one line in the config fragment, BR2_PACKAGE_PYTHON=y or
> So we replace one fairly explicit line:
> by just another line, which requires going to the base class to
> understand what is does:
> 	python_version = 2
> I.e, I am wondering if this refactoring is really useful in the end ?

Please let me send a v3, based from v1, doing the minimum to accomplish this
 - add common logic to test python packages with a script in a separate file
   instead of inline in the testcase
... and following these ideas:
 - use separate class
 - use no hacks/tricks
 - use explicit code

>From this v3 we can decide the direction to follow: whether to drop the series
or do some additional change, either as v4 or as followup patches.


More information about the buildroot mailing list