[Buildroot] [PATCH v2] support/download/file: fix file:// protocol handling

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun May 13 20:26:11 UTC 2018


Hello,

On Tue,  8 May 2018 15:28:31 +0200, Angelo Compagnucci wrote:
> When a file is used a source for download using the file:// protocol, a
> malformed url is passed to the file download script which then crashes.
> Following an example of a wrong path passed to the script:
> 
> eval cp -v ''\''file:///home/angelo/DEV/TOOLCHAINSarmv7-eabihf--glibc--bleeding-edge-2017.11-1.tar.bz2'\''' ''\''/home/angelo/DEV/BUILDROOT/br_qemu_arm/build/.armv7-eabihf--glibc--bleeding-edge-2017.11-1.tar.bz2.f403PT/output'\'''.
> 
> Path passed to cp lacks of a / between dir and file part of the url,
> moreover it presents a wrong file:// prefix.
> 
> Fixes:
> 
> cp: cannot stat
> 'file:///home/angelo/DEV/TOOLCHAINSarmv7-eabihf--glibc--bleeding-edge-2017.11-1.tar.bz2':
> No such file or directory
> 
> Signed-off-by: Angelo Compagnucci <angelo at amarulasolutions.com>
> ---
>  support/download/file | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master after reworking the commit log. Thanks Angelo!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list