[Buildroot] [PATCH v2 1/2] toolchain/buildroot: Fix symbol for uClibc
thomas.petazzoni at bootlin.com
Sun May 13 19:19:43 UTC 2018
On Wed, 9 May 2018 18:33:22 +0200, Petr Vorel wrote:
> Symbol BR2_TOOLCHAIN_UCLIBC doesn't exist, it was meant to be
> Fixes: 493b1177b9 toolchain/buildroot: default to uClibc
> Signed-off-by: Petr Vorel <petr.vorel at gmail.com>
> toolchain/toolchain-buildroot/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in
> index 2f6624d217..75e8191f46 100644
> --- a/toolchain/toolchain-buildroot/Config.in
> +++ b/toolchain/toolchain-buildroot/Config.in
> @@ -22,7 +22,7 @@ config BR2_TOOLCHAIN_BUILDROOT_VENDOR
> prompt "C library"
> - default BR2_TOOLCHAIN_UCLIBC
> + default BR2_TOOLCHAIN_BUILDROOT_UCLIBC
Just like I added a checker in check-package to verify automatically
the issue raised by PATCH 2/2 of Petr's series , I wanted to add a
checker to detect the problem raised by this patch.
My idea was to have something that:
(1) Collects options defined by "config BR2_<something>"
(2) Collects references to option, in "select", "depends on",
"default" clauses, etc.
(3) Ensures that all references to options have a matching option
However, this requires a global pass on all Config.in files to do (1)
and (2) before doing (3), and I'm not sure how this fits in the current
check-package logic, which seems very per-file oriented.
What do you think about this ? Should this be done as part of
check-package, or a separate checker ?
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
More information about the buildroot