[Buildroot] [PATCH] busybox: S01mdev: fix module autoloading

Peter Korsgaard peter at korsgaard.com
Mon May 7 16:03:01 UTC 2018

Commit b4fc5a180c (package/busybox: support spaces in module aliases in
mdev) changed the mdev coldplugging to handle sysfs path elements containing
spaces.  This unfortunately doesn't work as was recently reported:


The problem is that sort -z also expects the fields of the input files to be
zero terminated, which is not the case for modalias sysfs entries.

To my knowledge, no modalias entries contain spaces so fix it by dropping
the -z option to sort and adjusting the xargs invocation to match.  The find
invocation and first xargs invocation still uses -print0 / -0, so sysfs
paths containing spaces are still handled correctly.

Spaces in modalias entries could be handled with the xargs -d '\n' option,
but that is unfortunately not supported by the busybox applet.

Reported-by: Daniel Palmer <daniel at 0x0f.com>
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
 package/busybox/S10mdev | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/busybox/S10mdev b/package/busybox/S10mdev
index 63ca955b1c..2ba391a5df 100644
--- a/package/busybox/S10mdev
+++ b/package/busybox/S10mdev
@@ -9,7 +9,7 @@ case "$1" in
 	echo /sbin/mdev >/proc/sys/kernel/hotplug
 	/sbin/mdev -s
 	# coldplug modules
-	find /sys/ -name modalias -print0 | xargs -0 sort -u -z | xargs -0 modprobe -abq
+	find /sys/ -name modalias -print0 | xargs -0 sort -u | xargs modprobe -abq

More information about the buildroot mailing list