[Buildroot] [PATCH 1/1] toolchain-external-custom: allow specifying relative path to binaries

Calin Crisan ccrisan at gmail.com
Sun Mar 25 08:46:48 UTC 2018


Yann, I have posted a v2 that fixes this and another issue with supported
external toolchains. Please let me know if there's anything else that needs
to be addressed.

Thanks,

Calin.

On Sun, Mar 25, 2018, 11:35 Yann E. MORIN <yann.morin.1998 at free.fr> wrote:

> Calin, All,
>
> On 2018-03-23 23:40 +0200, Calin Crisan spake thusly:
> > There are cases where a downloaded toolchain doesn't have its binaries
> > placed directly in a "bin" subfolder (where BuildRoot currently looks
> > for them).
> >
> > A common example is the official Raspberry Pi Toolchain
> > (https://github.com/raspberrypi/tools), which has its binaries in
> > "arm-bcm2708/arm-linux-gnueabihf/bin".
> >
> > This commit introduces BR2_TOOLCHAIN_EXTERNAL_BIN_PATH that defaults
> > to "bin" and can be changed as needed.
> >
> > Signed-off-by: Calin Crisan <ccrisan at gmail.com>
> > ---
> >  toolchain/toolchain-external/pkg-toolchain-external.mk            | 2
> +-
> >  .../toolchain-external-custom/Config.in.options                   | 8
> ++++++++
> >  2 files changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk
> b/toolchain/toolchain-external/pkg-toolchain-external.mk
> > index 3bf9fac412..4dfe3815ae 100644
> > --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> > +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> > @@ -77,7 +77,7 @@ ifneq ($(TOOLCHAIN_EXTERNAL_PREFIX),)
> >  TOOLCHAIN_EXTERNAL_BIN := $(dir $(shell which
> $(TOOLCHAIN_EXTERNAL_PREFIX)-gcc))
> >  endif
> >  else
> > -TOOLCHAIN_EXTERNAL_BIN = $(TOOLCHAIN_EXTERNAL_INSTALL_DIR)/bin
> > +TOOLCHAIN_EXTERNAL_BIN = $(TOOLCHAIN_EXTERNAL_INSTALL_DIR)/$(call
> qstrip,$(BR2_TOOLCHAIN_EXTERNAL_BIN_PATH))
> >  endif
> >
> >  # If this is a buildroot toolchain, it already has a wrapper which we
> want to
> > diff --git
> a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > index 70c7d8e3c3..bb199aab85 100644
> > ---
> a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > +++
> b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > @@ -12,6 +12,14 @@ config BR2_TOOLCHAIN_EXTERNAL_URL
> >       help
> >         URL of the custom toolchain tarball to download and install.
> >
> > +config BR2_TOOLCHAIN_EXTERNAL_BIN_PATH
> > +    string "Toolchain bin path"
> > +    default "bin"
> > +    depends on BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD
> > +    help
> > +      Path to where the binaries (e.g. the compiler) can be found,
> > +      relative to the downloaded toolchain root directory.
>
> Indentation is incorrect: it should be a leading TAB for option, and a
> leading TAB and two spaces for the help text.
>
> See:
>
> https://buildroot.org/downloads/manual/manual.html#writing-rules-config-in
>
> Otherwise, looks sensible to me...
>
> Regards,
> Yann E. MORIN.
>
> >  config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX
> >       string "Toolchain prefix"
> >       default "$(ARCH)-linux"
> > --
> > 2.16.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180325/f80f60e4/attachment-0002.html>


More information about the buildroot mailing list