[Buildroot] [PATCH next v2 3/5] support/scripts/pkg-stats-new: add current version information
thomas.petazzoni at bootlin.com
Thu Mar 8 07:48:08 UTC 2018
On Thu, 08 Mar 2018 00:14:51 -0300, Ricardo Martincoski wrote:
> > With this:
> > - If the package specifies only a target version, the target version
> > is saved.
> > - If the package specifies only a host version, the host version is
> > saved.
> > - If the package specifies both a target version and a host version,
> > the target version always wins. So the scripts doesn't handle
> > differentiating host and target versions for the same package, but
> > at least we are consistent in the fact that we will always report
> > the target version.
> > How does that sound ?
> Sounds good.
> Nit: please recheck with flake8.
> > I'm just cutting after 20 characters, and adding "..." at the end, and
> > it seems good enough to me (compared to doing a regexp to try to guess
> > if it's a git hash or not).
> OK since you are only changing the display of the version, not the string that
> will be compared to the new column.
> The few version strings in the tree that are not sha1 larger than 20 are:
> For me these are OK:
Yes, I'm only changing the display of the version, and I'm also adding
"..." which helps the reader understand that the version string has
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
More information about the buildroot