[Buildroot] [PATCH v4 0/8] Introduce a golang-package infrastructure

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Mar 31 18:39:52 UTC 2018


Hello,

On Sat, 31 Mar 2018 20:00:43 +0200, Arnout Vandecappelle wrote:
> On 31-03-18 15:27, Thomas Petazzoni wrote:
> > Hello,
> > 
> > This v4 is a new iteration of the work done by Angelo Compagnucci to
> > introduce a golang package infrastructure. Note that in its v3 of the
> > series, Angelo had a PATCH 7/7 that was adding 'mender' as a new
> > package, but this specific patch is not part of this series.  
> 
>  Series applied, with the exception of 7/8 which had a relevant comment from Yann:
> 
>    So, where do you now enforce a static build when
>    BR2_PACKAGE_DOCKER_ENGINE_STATIC_CLIENT is set?
> 
>  Angelo, could you respin that patch together with mender?

I took care of PATCH 7/8, which converts docker-engine to the
golang-package infrastructure, re-adding the code handling
BR2_PACKAGE_DOCKER_ENGINE_STATIC_CLIENT.

So the Mender patch remains. I don't think Angelo really needs to
respin it, since we haven't reviewed it (yet).

>  I also made some changes to pkg-golang.mk:
> 
>      - Rewrap comments to 80 columns.
>      - Create a global definition of GO_TARGET_ENV.
>      - <PKG>_GO_ENV is appended to the default env instead of replacing it.
>      - Add a note to inner-golang-package that only target is supported.
> 
>  Angelo, please review those and send follow-up patches if you don't agree with
> any of it.
> 
>  Thank you for the persistence on this one! And thank you Yann for reviewing.

And thank you for doing a final review on this series!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list