[Buildroot] [PATCH 1/2] Makefile: move mkdir rule to after HOST_DIR is defined

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Mar 31 16:58:00 UTC 2018


Hello,

On Fri, 4 Aug 2017 18:31:29 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> HOST_DIR is defined twice: once to its default value before .config is
> included, and once more to BR2_HOST_DIR after .config is included.
> However, the rule that defines the mkdir for HOST_DIR comes between
> these two, so it will always use the default definition. Therefore,
> if a non-default BR2_HOST_DIR is used, there will be no rule to create
> that directory, while the dirs target depends on it.
> 
> This happens to work at the moment, because in the dirs target,
> $(STAGING_DIR) comes before $(HOST_DIR), so $(HOST_DIR) will be created
> implicitly. However, this will fail in top-level parallel builds where
> both will be created in parallel.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> ---
>  Makefile | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)

Both applied to master. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list