[Buildroot] [PATCH 1/2] core/intrumetnation: don't spawn to get seconds-since-EPOCH

Cam Hutchison cam at camh.ch
Sat Mar 17 11:54:12 UTC 2018


On 16 March 2018 at 07:35, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> No need to spawn $(date) to get the number of seconds-since-EPOCH, as
> bash's printf can do it as easily.
>
> This is just a micro-optimisation, though. Probably not noticeable.
>
> Reported-by: Trent Piepho <tpiepho at impinj.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Trent Piepho <tpiepho at impinj.com>
> ---
>  package/pkg-generic.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 9eddaeee57..2a82025a04 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -49,8 +49,8 @@ endef
>
>  # Time steps
>  define step_time
> -       printf "%s:%-5.5s:%-20.20s: %s\n"           \
> -              "$$(date +%s)" "$(1)" "$(2)" "$(3)"  \
> +       printf "%(%s)T:%-5.5s:%-20.20s: %s\n"           \
> +              -1 "$(1)" "$(2)" "$(3)"  \

Should you note somewhere that this needs bash 4.2? I remember some
re-working of bash patches in the past to avoid the use of associative arrays
as they were not supported in the oldest version of bash supported by
buildroot. Is bash 4.2 ok now?

See http://tiswww.case.edu/php/chet/bash/NEWS for when features were
added to bash.

>                >>"$(BUILD_DIR)/build-time.log"
>  endef
>  GLOBAL_INSTRUMENTATION_HOOKS += step_time
> --
> 2.14.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot


More information about the buildroot mailing list