[Buildroot] [PATCH] git-download: Fix downloading of specific revisions from github.

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Jun 26 19:38:47 UTC 2018


Hello,

On Tue, 26 Jun 2018 11:36:17 +0200, Sven Neumann wrote:

> diff --git a/support/download/git b/support/download/git
> index 11bb52c1e1..1efde4fcdc 100755
> --- a/support/download/git
> +++ b/support/download/git
> @@ -75,6 +75,12 @@ _git() {
>      eval GIT_DIR="${git_cache}/.git" ${GIT} "${@}"
>  }
>  
> +# If the URL contains github, simply fetch the archive via wget:
> +if [[ $repo == https://api.github.com/* ]]; then
> +    wget -O $output $repo
> +    exit 0
> +fi

This looks weird. Why would downloads from https://<something> end up
in the Git download helper ?

If the URL starts with https://, unless the SITE_METHOD is forced to
Git, then it's the wget download helper that gets used.

Downloads that use the $(call github,...,...) macro today already use
wget, not git.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list