[Buildroot] [PATCH 1/1] Use one call to mkdir to create needed directories.

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Jun 5 13:06:41 UTC 2018


Hello,

On Tue, 5 Jun 2018 14:36:11 +0200, Florian La Roche wrote:
> Reduce this to only call mkdir once to create the needed directories.
> 
> 
> Signed-off-by: Florian La Roche <F.LaRoche at pilz.de>

Thanks for all your patches. Generally they look good to me in terms of
contents, but there are a few minor formatting issues that would make
them better:

 - The commit title should include a prefix of the package being
   impacted.

 - The commit title should often be a bit shorter.

 - The commit log should contain only one empty line before the SoB
   line, not two empty lines.

 - A non empty commit log would be better, to give additional
   explanations when necessary.

For this patch, a better commit log would for example be:

busybox: reduce number of mkdir calls in inittab

The default Busybox inittab does two separate mkdir calls to
create /dev/pts and /dev/shm, which is not necessary. Let's refactor
those two calls into a single one.

Signed-off-by: ...

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list