[Buildroot] [PATCH 1/1] gnuradio: needs host-python2

Baruch Siach baruch at tkos.co.il
Thu Jun 28 03:25:58 UTC 2018


Hi Fabrice,

On Wed, Jun 27, 2018 at 06:24:34PM +0200, Fabrice Fontaine wrote:
> 2018-06-27 7:35 GMT+02:00 Fabrice Fontaine <fontaine.fabrice at gmail.com>:
> > 2018-06-27 5:36 GMT+02:00 Baruch Siach <baruch at tkos.co.il>:
> >> On Tue, Jun 26, 2018 at 11:43:26PM +0200, Fabrice Fontaine wrote:
> >> > gnuradio needs host-python2 however there is no way to enforce this so
> >> > add a dependency on !BR2_PACKAGE_PYTHON3.
> >> > Indeed, if BR2_PACKAGE_PYTHON3 is selected, then buildroot will only
> >> > build host-python3.
> >>
> >> Why not just add host-python to _DEPENDENCIES?
> >>
> > Indeed, I will update my patch. Thanks for your help.
>
> After testing this option, this does not work. host-python2 is indeed built
> but host-python3 is also built.
> As a result, host-python-mako and host-python-six are built only for
> host-python3 and not for host-python2. I don't know if this the expected
> behavior,perhaps buildroot should always build the python2 and python3 host
> packages?

Not sure what the right solution here is.

Yegor, do you have an idea?

baruch

> >> > This issue was not raised in the previous version of gnuradio as
> >> > host-python-cheetah was the only dependency and host-python-cheetah
> >> > enforces python2 through HOST_PYTHON_CHEETAH_NEEDS_HOST_PYTHON however
> >> > we now have host-python-six and host-python-mako dependencies and it
> >> > does not seem right to enforces python2 on those packages
> >> >
> >> > Fixes:
> >> >  - http://autobuild.buildroot.net/results/a502fef3e2a40f38ca633
> >> 32440b0b6bd2ed11d5a
> >> >
> >> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> >> > ---
> >> >  package/gnuradio/Config.in | 2 ++
> >> >  1 file changed, 2 insertions(+)
> >> >
> >> > diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
> >> > index f748b902a7..25131fb105 100644
> >> > --- a/package/gnuradio/Config.in
> >> > +++ b/package/gnuradio/Config.in
> >> > @@ -1,5 +1,6 @@
> >> >  comment "gnuradio needs a toolchain w/ C++, NPTL, wchar, dynamic
> >> library"
> >> >       depends on BR2_USE_MMU
> >> > +     depends on !BR2_PACKAGE_PYTHON3
> >> >       depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> >> >               !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
> >> >
> >> > @@ -10,6 +11,7 @@ config BR2_PACKAGE_GNURADIO
> >> >       depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> >> >       depends on BR2_USE_MMU # use fork()
> >> >       depends on BR2_USE_WCHAR # boost
> >> > +     depends on !BR2_PACKAGE_PYTHON3
> >> >       select BR2_PACKAGE_BOOST
> >> >       select BR2_PACKAGE_BOOST_DATE_TIME
> >> >       select BR2_PACKAGE_BOOST_FILESYSTEM

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -


More information about the buildroot mailing list