[Buildroot] [PATCH 0/8] imx: update multimedia packages to 4.9.88_2.0.0_ga
arnout at mind.be
Sat Jul 28 08:08:32 UTC 2018
On 26-07-18 11:58, Gary Bisson wrote:
> On Thu, Jul 26, 2018 at 11:45:21AM +0200, Thomas Petazzoni wrote:
>> On Thu, 26 Jul 2018 11:26:51 +0200, Arnout Vandecappelle wrote:
>>> I'm sorry for all the work that you did, but I don't really agree that this is
>>> a good idea. The upstream package really is called imx-vpu, so we prefer to keep
>>> that name. We changed the name for openssl because there really was no other
>>> way, but I do prefer to avoid that.
>>> So I think it's just a matter of finding a better name for the virtual package.
>>> What about imx-vpu-provider?
>> I have not reviewed the patch series carefully enough yet, but a
>> question is: do we need a virtual package at all?
> Up to you, I'm ok either way, just thought it'd be cleaner this way.
If you don't use the virtual package infra, the code just gets a little more
difficult to understand, so I really don't see a reason NOT to use the virtual
package infra. Yes, a virtual package is a little more verbose than "manually"
handling it, but it's a pattern that is understandable. The only disadvantage
that I see is that you have to find a name for it :-)
That said, since there are only two users, doing it manually isn't that bad
either. So if you've already done the work, please stick to it and don't keep
running around in circles...
>> I guess the imx-vpu API is not going to be used by gazillions of
>> packages. If I read PATCH 5/8 correctly, it's in fact only used by two
>> packages, right ?
> Yes, libimxvpuapi and imx-vpuwrap are the only 2 users of imx-vpu right
>> Can't we simply have those two packages do:
>> ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M),y)
>> use the new imx-vpu package
>> use the old imx-vpu package
>> And ditto in their Config.in ?
>> Virtual packages are great when there is really an arbitrary number of
>> providers and/or an arbitrary number of users.
>> OpenSSL for examples has only two providers, but it has a very large
>> number of users. Ditto jpeg. MySQL does not have a lot of users, but it
>> might potentially have.
>> Also, the i.MX VPU stuff is highly platform-specific, it provides a
>> very specialized API, it's very unlikely that we will see gazillions of
>> packages depending on the i.MX VPU API.
> Ok, I'll make a v3 like this then.
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
More information about the buildroot