[Buildroot] [PATCH v2 1/1] pkg-generic: fix no-check-hash for inferred site method
peter at korsgaard.com
Thu Jul 19 21:35:03 UTC 2018
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski at gmail.com> writes:
> Currently, when the site method is explicitly set to a SCM other than
> git, the main download is correctly excluded from being hash-checked.
> But when the site method is inferred from the site uri, the download
> from a SCM other than git is wrongly being hash-checked.
> Fix this by moving the code that excludes SCM methods from hash-check
> below the code that infers the site method.
> Currently there is no package in the tree that uses inferred site
> method, and that is why the autobuilder didn't caught this. We had
> packages using inferred site method in the past, the last one was
> 'expect', but since they didn't have a hash file (for a license or
> extra-download for example) the build didn't error out.
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
> Cc: Luca Ceresoli <luca at lucaceresoli.net>
> Cc: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
> Reviewed-by: Luca Ceresoli <luca at lucaceresoli.net>
> Tested-by: Luca Ceresoli <luca at lucaceresoli.net>
> Changes v1 -> v2:
> - improve commit message (Luca Ceresoli);
> - collect Reviewed-by & Tested-by tags.
> package/pkg-generic.mk | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Committed to 2018.05.x, thanks.
Bye, Peter Korsgaard
More information about the buildroot