[Buildroot] [PATCH v2] qt5webengine: propagate parallel flag to ninja

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Jul 1 09:05:07 UTC 2018


On Fri, 29 Jun 2018 10:35:21 -0400, Gaël PORTAY wrote:
> WebEngine is a big project to build. It uses ninja which is a build
> system that does everything in parallel[1].
> 	Builds are always run in parallel, based by default on the number of
> 	CPUs your system has. Underspecified build dependencies will result in
> 	incorrect builds.
> QtWebEngine does not propagate the parallel flag from the running
> instance of make to ninja. Thus, all the machine cores are used to build
> this single project.
> 	make -j 10 -> ninja -j # all cores
> This behavior disrupts powerful machines which are setup to build many
> projects in parallel. Even worse, the build fails on machines where the
> ratio CPU-cores / amount of RAM (including swap) is not appropriate. g++
> may have not enough of memory to build all those files in parallel.
> Unfortunatly, the target `run_ninja' is hardcoded in the Makefile
> src/core/Makefile.run_gn; there is no way to propagate flags using a
> variable through the make command-line.
> 	run_ninja:
> 	        /home/gportay/src/buildroot/output-qt5.11/build/qt5webengine-5.11.1/src/3rdparty/ninja/ninja
> -C /home/gportay/src/buildroot/output-qt5.11/build/qt5webengine-5.11.1/src/core/release QtWebEngineCore
> Luckily, the Qt gn_run.pro[2] can hardcode ninja extra flags through the
> variable NINJAFLAGS when the Makefile is generated (which is performed
> during the build and not during configure step).
> This commit sets the NINJAFLAGS using the variable PARALLEL_JOBS to limit
> the number of cores used by ninja.
> Fixes:
> 	virtual memory exhausted: Cannot allocate memory
> [1]: https://ninja-build.org/manual.html#_comparison_to_make
> [2]: https://github.com/qt/qtwebengine/blob/v5.11.1/src/core/gn_run.pro#L49-L53
> CC: Damien Riegel <damien.riegel at savoirfairelinux.com>
> CC: Jean-François Têtu <jean-francois.tetu at savoirfairelinux.com>
> Signed-off-by: Gaël PORTAY <gael.portay at savoirfairelinux.com>
> ---
> Changes since v1:
>  - Use PARALLEL_JOBS instead of BR2_JLEVEL
>  - Reword commit message

Applied to master, thanks.

Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering

More information about the buildroot mailing list