[Buildroot] [PATCH 1/1] Main Makefile Have "make savedefconfig" show where the file is being written to.

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Feb 27 21:02:00 UTC 2018


On Tue, 27 Feb 2018 03:28:18 -0800, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc at gmail.com>

The commit title should be shorter, perhaps:

	Makefile: show defconfig file being saved in 'savedefconfig'

and then the commit log should expand on that, to explain why this is

> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> diff --git a/Makefile b/Makefile
> index ec39bcdb9c..4ac2435a9c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -927,6 +927,7 @@ savedefconfig: $(BUILD_DIR)/buildroot-config/conf prepare-kconfig
>  		--savedefconfig=$(if $(DEFCONFIG),$(DEFCONFIG),$(CONFIG_DIR)/defconfig) \
>  	@$(SED) '/BR2_DEFCONFIG=/d' $(if $(DEFCONFIG),$(DEFCONFIG),$(CONFIG_DIR)/defconfig)
> +	@echo "Saved to $(DEFCONFIG)"

I'm personally OK with this, and believe it makes sense. I've always
found it weird that we automatically save back to the defconfig we have
started from, but some people liked that. More than once I've been
puzzled after a "make savedefconfig" to not find a "defconfig" file in
the current folder, because the defconfig had been updated in
configs/<something>_defconfig. So to me, your change makes sense.

Could you respin after fixing the commit title, and expanding a bit the
commit log ?

Thanks a lot!

Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering

More information about the buildroot mailing list