[Buildroot] [PATCH 1/2] pkgconf: pkg-config.in: double quote $@

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Feb 22 15:49:49 UTC 2018


Hello,

On Wed, 21 Feb 2018 18:48:54 -0500, Gaël PORTAY wrote:

> > Could you give more details about what this is fixing, i.e a specific
> > scenario that is fixed by this patch ?  
> 
> In the case pkgconf, I can not see a real situation where this patch
> fixes an issue.
> 
> There is an important difference between $@ and "$@". The shell expands
> "$@" as "$1" "$2" "$3"... while it expands $@ as $1 $2 $3.
> 
> With the second form, we losts spaces in positional parameters.
> 
> As example, the following call
> 
> 	pkg-config --cflags "one two" three
> 
> is wrapped as
> 
> 	pkgconf --cflags one two three
> 
> while we are expecting
> 
> 	pkgconf --cflags "one two" three
> 
> "$@" is really useful when writing wrappers. It passes the positional
> arguments *as* they are given.

OK, thanks for the explanation, makes sense. A better commit log would
definitely help :)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com


More information about the buildroot mailing list