[Buildroot] [PATCH v1 2/2] dhcp: disable isc assertions (reproducible builds)

Peter Korsgaard peter at korsgaard.com
Sat Feb 3 21:54:44 UTC 2018


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

Hi,

 >> Peter, Arnout, Yann, what do you think, especially about the
 >> assertions ?

 > Assertions are supposed to be usefull during development, not during
 > production use, so I would be fine with disabling them, yes.

 > At least, I would hope that no sane developer uses assertions to check
 > for normal error conditions in normal operation mode... ;-]

Agreed, and the space savings are quite big - So committed, thanks.

 > Now, about reproducibility... We could at least pass -DFILE=\"\" and so
 > on from inside our gcc-wrapper, like we already do for __DATE__ and
 > __TIME__. Yes, that would give an empty filename in assertions and the
 > likes, but do we care in the end?

It would be nicer if we could pass basename($file), but that would break
with compilations with multiple source files passed to gcc or header
files, so yeah, perhaps that is the best way forward.

How does E.G. Debian handle it?

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list