[Buildroot] [PATCH v3 2/4] skeleton: use BR2_SYSTEM_DEFAULT_PATH as default PATH

Markus Mayer mmayer at broadcom.com
Mon Dec 31 00:13:20 UTC 2018


On Sun, 30 Dec 2018 at 13:52, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello,
>
> On Thu, 20 Dec 2018 09:58:12 -0800, Markus Mayer wrote:
> > We substitute the path specified in system/skeleton/etc/profile with
> > the path specified in the configuration variable
> > $(BR2_SYSTEM_DEFAULT_PATH).
> >
> > $(BR2_SYSTEM_DEFAULT_PATH) is a Kconfig string. So it is already
> > quoted, which is exactly what we want.
>
> I am curious about this sentence: why is it "exactly what we want" ?
>
> > diff --git a/system/skeleton/etc/profile b/system/skeleton/etc/profile
> > index 1255d23ff40d..db29e44920e8 100644
> > --- a/system/skeleton/etc/profile
> > +++ b/system/skeleton/etc/profile
> > @@ -1,4 +1,4 @@
> > -export PATH=/bin:/sbin:/usr/bin:/usr/sbin
> > +export PATH=@PATH@
>
> Indeed, the variable assignment was not double quoted before, and now
> it becomes double quoted:
>
> export PATH="/bin:/sbin:/usr/bin:/usr/sbin"
>
> is what I have in the resulting /etc/profile.
>
> So does "exactly what we want" means "preserves the existing behavior"
> or means "is better than the existing behavior" for some reason ?

I hadn't actually noticed this difference in quoting, but it does seem
like a good idea to have them.

"Exactly what we want" was just meant to indicate that we get a quoted
string out of Kconfig, and we can use that quoted string in our code
unchanged (explaining why there are no quotes being added in the code
and why they aren't being stripped, either).

This can be reworded if you think it is too confusing.

Regards,
-Markus

> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com


More information about the buildroot mailing list