[Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Dec 29 09:44:44 UTC 2018


Hello,

On Fri, 28 Dec 2018 20:46:50 -0800, Christian Stewart wrote:

> On Fri, Dec 28, 2018 at 7:07 AM Thomas Petazzoni
> <thomas.petazzoni at bootlin.com> wrote:
> > When libsseccomp support is enabled, docker-containerd uses pkg-config
> > to find libsseccomp, so we must depend on host-pkconf.
> > +DOCKER_CONTAINERD_DEPENDENCIES += libseccomp host-pkgconf  
> 
> LGTM.

Thanks for the review.

> Signed-off-by: Christian Stewart <christian at paral.in>
> 
> - I hope signed-off-by is appropriate here.

Signed-off-by is when you're the author, or in the chain of
developers/maintainers that carry the patch all the way to upstream.

In this case, what you should ideally have used is a Acked-by or
Reviewed-by. See also
https://buildroot.org/downloads/manual/manual.html#_reviewing_and_testing_patches.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list