[Buildroot] [PATCH v3 1/3] package/waf: add a blind Config.in.host
thomas.petazzoni at bootlin.com
Wed Dec 26 21:30:05 UTC 2018
On Sun, 23 Dec 2018 15:19:48 -0200, Carlos Santos wrote:
> The plan for the future is:
> * All host packages have a Config.in.host option.
> * The host packages that are only build dependencies of other packages
> have a blind Config.in.host option
> * The host packages that are useful by themselves continue to have a
> visible Config.in.host option.
> host-waf gets a blind Config.in.host, because it exists only to build
> Waf-based packages that set <PKG>_NEEDS_EXTERNAL_WAF to YES.
> A help text is included to document the package, only, since it is not
> shown in the configuration menu.
> Signed-off-by: Carlos Santos <casantos at datacom.com.br>
> Changes v1->v2:
> - Explain the motivation in the commit message
In fact the commit message doesn't explain the actual motivation. What
prompted you to add a blind Config.in.host option for waf
specifically ? Is this just a part of "let's start adding blind option
for all host packages", or is there a specific issue with host-waf that
this blind Config.in.host option will allow to solve ?
I.e: I am all in favor of this change, but I'm just curious to
understand why you did it in the first place.
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 16b474fc9d..3644436fe3 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -64,6 +64,7 @@ menu "Host utilities"
> source "package/uboot-tools/Config.in.host"
> source "package/util-linux/Config.in.host"
> source "package/vboot-utils/Config.in.host"
> + source "package/waf/Config.in.host"
> source "package/xorriso/Config.in.host"
> source "package/zip/Config.in.host"
> source "package/zstd/Config.in.host"
I'm not sure it's really nice to include all the host packages
Config.in.host files inside the "Host utilities" menu. In practice,
it's a blind option so it doesn't matter much, but it will clutter a
lot this list, making it difficult to see which one is there to be
really visible in menuconfig, and which one is here just so that the
kconfig machinery knows about all those blind options.
I think I would prefer a new list, at the bottom of
package/Config.in.host, outside of the Host utilities menu.
Let's see what Arnout/Peter/Yann have to say about this.
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
More information about the buildroot