[Buildroot] [EXT] Re: [PATCH] boot/mv-ddr-marvell: support custom GIT settings

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Dec 26 10:31:53 UTC 2018


Hello Kostya,

On Tue, 25 Dec 2018 09:09:26 +0000, Kostya Porotchkin wrote:

> > As I see you're an @marvell.com, do you need that to use an internal
> > repository during development? If so, then why can't you just use the
> > OVERRIDE_SRCDIR mechanism instead?  
> [KP] It is more than just a local repository. I have to allow CI server to automatically build test and release images from the current internal GIT trees.

Sorry, but this is not a valid justification. With this justification,
we would have to add version selection to *all* Buildroot packages.
Indeed, one might want to do CI testing on any random user-space
library or application. So if your use-case for wanting version
selection in mv-ddr-marvell is CI testing, then we won't accept this
patch.

However, if people porting ATF/U-Boot to new Marvell-based platforms
need to have their own custom version of mv-ddr-marvell, then having
version selection can be accepted because it puts this package in the
same situation as uboot, linux or atf, where we do offer version
selection.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list