[Buildroot] [PATCH 1/1] iptables: add patch to fix symlink path of iptables-xml

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Dec 22 07:04:55 UTC 2018


Hello,

On Fri, 21 Dec 2018 16:29:59 -0700, Joel Carlson wrote:

> +diff --git a/iptables/Makefile.am b/iptables/Makefile.am
> +index f92cc4ff..fe5195d7 100644
> +--- a/iptables/Makefile.am
> ++++ b/iptables/Makefile.am
> +@@ -88,7 +88,7 @@ pkgconfig_DATA = xtables.pc
> + install-exec-hook:
> + 	-if test -z "${DESTDIR}"; then /sbin/ldconfig; fi;
> + 	${INSTALL} -dm0755 "${DESTDIR}${bindir}";
> +-	for i in ${vx_bin_links}; do ${LN_S} -f "${sbindir}/xtables-multi" "${DESTDIR}${bindir}/$$i"; done;
> ++	for i in ${vx_bin_links}; do ${LN_S} -f "${DESTDIR}${sbindir}/xtables-multi" "${DESTDIR}${bindir}/$$i"; done;

For the target installation, this looks wrong. It means you would have
on the target a link that points
to /the/original/path/to/where/buildroot/was/built/output/target/sbin/xtables-multi.
Doesn't sound good.

A relative symlink instead would fix the problem.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list