[Buildroot] [PATCH v2 2/2] [RFC] package/pkg-waf.mk: mimic selection of host-waf
thomas.petazzoni at bootlin.com
Fri Dec 21 15:34:30 UTC 2018
On Thu, 20 Dec 2018 22:22:21 -0200, Carlos Santos wrote:
> Since host-waf's Config.in.host is blind, it is not possible to select
> it in the configuration menu. There are two possible solutions for this
> - Add "select BR2_PACKAGE_HOST_WAF" to package/mpv/Config.in (currently
> only mpv requires host-waf). Also, document that BR2_PACKAGE_HOST_WAF
> must be selected when <PKG>_NEEDS_EXTERNAL_WAF is YES.
> - Set BR2_PACKAGE_HOST_WAF to 'y' in the waf-package macro. This one is
> simpler because it does not require changing anything else.
> Signed-off-by: Carlos Santos <casantos at datacom.com.br>
I understand the idea that doing this avoids repeating a "select
BR2_PACKAGE_HOST_WAF" in all packages using host-waf. However, I don't
think we want to go down the route of setting those variables from the
make logic. I don't have a very strong argument to defend this
position, but to me it looks more logical that we continue to use
kconfig-level "select" to enable those config options.
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
More information about the buildroot