[Buildroot] [PATCH v2 2/4] skeleton: use BR2_SYSTEM_DEFAULT_PATH as default PATH

Markus Mayer mmayer at broadcom.com
Wed Dec 19 23:24:48 UTC 2018


Hi Yann,

On Wed, 19 Dec 2018 at 13:34, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>
> Markus, All,
>
> > diff --git a/package/skeleton-init-common/skeleton-init-common.mk b/package/skeleton-init-common/skeleton-init-common.mk
> > index e8a052205268..866273bbd7ee 100644
> > --- a/package/skeleton-init-common/skeleton-init-common.mk
> > +++ b/package/skeleton-init-common/skeleton-init-common.mk
> > @@ -22,6 +22,7 @@ define SKELETON_INIT_COMMON_INSTALL_TARGET_CMDS
> >       $(call SYSTEM_LIB_SYMLINK,$(TARGET_DIR))
> >       $(INSTALL) -m 0644 support/misc/target-dir-warning.txt \
> >               $(TARGET_DIR_WARNING_FILE)
> > +     $(SED) 's, at PATH@,$(BR2_SYSTEM_DEFAULT_PATH),' $(TARGET_DIR)/etc/profile
>
> I think we should keep the warning file the last command executed.

I am not sure I am following. I am not doing anything to target-dir-warning.txt.

> Otherwise:
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>
> Regards,
> Yann E. MORIN.

Thanks,
-Markus


More information about the buildroot mailing list