[Buildroot] [PATCH 1/4] system cfg: introduce option BR2_SYSTEM_DEFAULT_PATH

Markus Mayer mmayer at broadcom.com
Tue Dec 18 21:22:25 UTC 2018


On Tue, 18 Dec 2018 at 11:27, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>
> Markus, All,
>
> On 2018-12-17 16:51 -0800, Markus Mayer spake thusly:
> > The configuration option BR2_SYSTEM_DEFAULT_PATH allows the user to
> > override the default path, which can be used by /etc/profile and some
> > system daemons.
> >
> > It defaults to the value previously hard-coded in /etc/profile. This
> > default should be suitable for most users.
> >
> > Signed-off-by: Markus Mayer <mmayer at broadcom.com>
> > ---
> >  system/Config.in | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/system/Config.in b/system/Config.in
> > index 0f77b9b6721a..93458c0011b7 100644
> > --- a/system/Config.in
> > +++ b/system/Config.in
> > @@ -386,6 +386,16 @@ comment "automatic network configuration via DHCP needs ifupdown or busybox or n
> >
> >  endif # BR2_ROOTFS_SKELETON_DEFAULT
> >
> > +config BR2_SYSTEM_DEFAULT_PATH
> > +     string "Set the system's default PATH"
> > +     default "/bin:/sbin:/usr/bin:/usr/sbin" if !BR2_ROOTFS_MERGED_USR
> > +     default "/bin:/sbin" if BR2_ROOTFS_MERGED_USR
>
> Do we really care to have a different value at all?
>
> In the merged-/usr case: if the command exists, it is found in either
> /bin or /sbin, and the lookup stops there. If the command does not
> exist, it is looked for in the four locations, instead of only two.
>
> This does not look like too much of an overhead, does it?
>
> Anyway, if we really want different values, then:
>   - we can simplify it a bit,
>   - and use the realy locations rahter than the  symlinks:
>
>     default "/usr/bin:/usr/sbin" if BR2_ROOTFS_MERGED_USR
>     default "/bin:/sbin:/usr/bin:/usr/sbin"
>
> (kconfig will stop on the fiurst default that is valid.)
>
> But for my part, I think a single default as is currently used is
> enough (i.e. /bin:/sbin:/usr/bin:/usr/sbin).

I am perfectly okay with a single value. That's how I had it
originally, until I saw Carlos' e-mail.

I'll let the powers that be make the call on this one. :-) If we do go
with two separate default values, I'll use the above simplification
(with just a single if).

Regards,
-Markus


More information about the buildroot mailing list