[Buildroot] [PATCH 1/1] kmod: fix build with pkgconf 1.5.3
peter at korsgaard.com
Fri Dec 14 22:41:43 UTC 2018
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice at gmail.com> writes:
>> Hmm, how did this work before if there wasn't anything to ensure
>> bash-completion was built before kmod? Just the alphabetical order?
> You're right, personally, I think that we should add a bash-completion
> dependency but bash-completion is not a "real" build time dependency,
> it's only needed to retrieve completionsdir.
> Because I was told to remove udev dependency from alsa-utils during
> review of https://patchwork.ozlabs.org/patch/1013180, I applied the
> same logic for kmod.
> Howerver if you want, I can send a new patch to add bash-completion dependency.
OK. As we now explicitly pass --with-completiondir (and hence not rely
on bash-completion.pc) and the install logic creates the destination
directory if needed, I don't think we really _NEED_ it.
Bye, Peter Korsgaard
More information about the buildroot