[Buildroot] [PATCH 1/1] kmod: fix build with pkgconf 1.5.3
peter at korsgaard.com
Fri Dec 14 20:29:02 UTC 2018
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice at gmail.com> writes:
> Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute
> paths found in the .pc file. This is correct when the paths refer to
> something in STAGING_DIR (e.g. libdir, includedir), but not when it
> refers to something used for the target.
> kmod uses the completionsdir variable from bash-completions.pc to decide
> where to install things. Since DESTDIR is prepended to the install
> destination, this will end up in the wrong location.
> Until a better solution is found in pkgconf, pass the appdefaultdir to
> use explicitly instead of relying on bash-completions.pc.
> - http://autobuild.buildroot.org/results/f8a1f956333062027294e766ff0ddab5c35d5887
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> package/kmod/kmod.mk | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk
> index c165ea3020..ea5d291133 100644
> --- a/package/kmod/kmod.mk
> +++ b/package/kmod/kmod.mk
> @@ -28,6 +28,10 @@ KMOD_CONF_OPTS = --disable-static --enable-shared
> KMOD_CONF_OPTS += --disable-manpages
> HOST_KMOD_CONF_OPTS = --disable-manpages
> +ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
> +KMOD_CONF_OPTS += --with-bashcompletiondir=/usr/share/bash-completion/completions
Hmm, how did this work before if there wasn't anything to ensure
bash-completion was built before kmod? Just the alphabetical order?
Anyway, committed - Thanks.
Bye, Peter Korsgaard
More information about the buildroot